Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table fill level #662

Merged

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Nov 19, 2024

Zrzut ekranu 2024-11-19 o 17 00 14

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced several new table components: FillerRow, FillerRows, SortIndicator, T, Tbody, Td, Th, Thead, and Tr, enhancing the table's rendering capabilities.
    • Added dynamic styling options for table cells and rows based on fill levels, selection states, and other properties.
    • Implemented hooks for scrolling detection and virtualized row management.
  • Improvements

    • Enhanced table stories to demonstrate various states, including empty data handling and highlighting.
  • Bug Fixes

    • Streamlined import paths for better organization and clarity in the component structure.

Copy link

linear bot commented Nov 19, 2024

@maciaszczykm maciaszczykm added the enhancement New feature or request label Nov 19, 2024
Copy link

coderabbitai bot commented Nov 19, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces several new components and updates existing ones in the table component library. Key additions include FillerRow, FillerRows, SortIndicator, and styled components such as T, Td, Th, Tr, and Tbody. The Table component has been modified to incorporate a new fillLevel property, enhancing its styling capabilities. Additionally, custom hooks for scrolling and virtual slice management have been added. The export paths have been updated, and new stories have been created for showcasing different table states, including an empty state.

Changes

File Path Change Summary
src/components/table/FillerRows.tsx Added FillerRow and FillerRows components for rendering customizable table rows.
src/components/table/SortIndicator.tsx Introduced SortIndicator component to visually indicate sorting direction in tables.
src/components/table/T.tsx Added styled component T for table element with customizable grid template columns.
src/components/table/Table.tsx Updated Table component with new fillLevel prop and modified rendering logic.
src/components/table/Tbody.tsx Created Tbody styled component for table body, wrapping TbodyUnstyled with context.
src/components/table/Td.tsx Introduced Td, TdExpand, and TdLoading styled components for table cells with dynamic styles.
src/components/table/Th.tsx Added styled component Th for table headers with various styling props.
src/components/table/Thead.tsx Created Thead styled component for table headers with sticky positioning.
src/components/table/Tr.tsx Introduced Tr styled component for table rows with dynamic styling based on props.
src/components/table/colors.ts Added constants and functions for managing styles based on table fill levels.
src/components/table/hooks.ts Introduced useIsScrolling and useOnVirtualSliceChange custom hooks for enhanced functionality.
src/index.ts Updated export path for Table component reflecting new directory structure.
src/stories/Table.stories.tsx Added new story Empty and updated existing stories to demonstrate various table states.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Table
    participant FillerRows
    participant SortIndicator

    User->>Table: Interacts with table
    Table->>FillerRows: Renders filler rows based on props
    Table->>SortIndicator: Displays sorting direction
    FillerRows-->>Table: Returns rendered rows
    SortIndicator-->>Table: Returns sorting icon
    Table-->>User: Displays updated table
Loading

🐰 "In the world of tables, oh what a sight,
Filler rows and sort icons, all shining bright.
With styles that dance and colors that play,
Our data's a feast, come join the array!
So hop along, dear friend, take a look and see,
The magic of tables, as fine as can be!" 🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning @pluralsh/eslint-config-typescript > [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning @pluralsh/eslint-config-typescript > eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning @pluralsh/eslint-config-typescript > @pluralsh/eslint-config-pluralsh > [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning @pluralsh/eslint-config-typescript > eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
error @pluralsh/[email protected]: The engine "node" is incompatible with this module. Expected version "18.19.0". Got "22.9.0"
error Found incompatible module.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 19, 2024

Visit the preview URL for this PR (updated for commit 34613ac):

https://pluralsh-design--pr662-marcin-prod-2901-add-z2fgnnlq.web.app

(expires Tue, 26 Nov 2024 16:05:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 784914c934330f8d0a9fd65c68898b3988262b7d

@maciaszczykm maciaszczykm marked this pull request as ready for review November 19, 2024 16:00
@maciaszczykm maciaszczykm requested a review from a team as a code owner November 19, 2024 16:00
@maciaszczykm maciaszczykm merged commit fb05211 into main Nov 20, 2024
13 checks passed
@maciaszczykm maciaszczykm deleted the marcin/prod-2901-add-fill-level-prop-to-table-component branch November 20, 2024 08:07
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 3.79.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants